Confusing arguments to PIDdrive during autonomous

team178 / TheClaaaw

2015 Competition Robot - Recycle Rush

1 stars 0 forks source link

Confusing arguments to PIDdrive during autonomous #7

Open robstolarz opened 9 years ago

robstolarz commented 9 years ago

https://github.com/team178/TheClaaaw/blob/master/src/org/usfirst/frc/team178/robot/Robot.java#L165 puts the speed parameter first, yet https://github.com/team178/TheClaaaw/blob/master/src/org/usfirst/frc/team178/robot/DriveTrain.java#L148 states that it's last

meaning our robot has been doing the strafe-and-turn completely wrong this whole time (how has it worked up until now ??)

edit: this is not the real issue. it is below

gluxon commented 9 years ago

My code works, I don't know why

Elizabeth-Cho commented 9 years ago

[image: Inline image 1]

On Mon, Apr 6, 2015 at 9:36 PM, Brandon Cheng notifications@github.com wrote:

[image: My code works, I don't know why] https://camo.githubusercontent.com/ff915058dcd97caa079140dd79cba5552d6e218d/68747470733a2f2f7062732e7477696d672e636f6d2f6d656469612f4136505357544643554149374e2d352e6a7067

— Reply to this email directly or view it on GitHub https://github.com/team178/TheClaaaw/issues/7#issuecomment-90307625.

Sapo! <(>o<)>

gluxon commented 9 years ago

I believe it still works because strafeSpeed is technically just an xValue. The code seems right to me.

robstolarz commented 9 years ago

Ah. It's a case of the misnamed variable. 0.8 is a speed (a magically-numbered speed that looks like an x- or twist-value), so we should comment that. strafeSpeed should be called strafeXValue or something like that. This is what I get for reviewing code with tired eyes. (Had to, to calculate the time savings for two-piece Autonomous)