search

team178 / team178.github.io

The 2nd Law Enforcers' Website
http://farmingtonrobotics.org
Mozilla Public License 2.0
14 stars 17 forks source link

The footer doesn't stick to the bottom of the page #102

Closed gisellegk closed 8 years ago

gisellegk commented 8 years ago

In really short pages (eg. /members/drive, /members/photos) the footer sticks to the bottom of the content. Then, there is white space between it and the bottom of the window.

TJScalzo commented 8 years ago

I attempted to fix this last meeting but the things I found on the internet didn't provide solutions that worked. This was due to the fact that the footer doesn't have a set height. However, even when I set one it still didn't work. I leave this issue in your care @gisellegk.

gisellegk commented 8 years ago

Haha yeah, I tried a couple things and it does some funky stuff... I'll take a closer look today

gisellegk commented 8 years ago

@TJScalzo @anusha2617 @poojpooj the changes are live. Can you check on IE/Edge and Safari? I tried Chrome on Android and Firefox and Chrome on Ubuntu. I think it should be fine for modern browsers...

The issue was a white bar below the footer on the Drive and Photos pages.

TJScalzo commented 8 years ago

Everything appears to be fixed... However, I'd test it on a larger display just in case.

TJScalzo commented 8 years ago

I've tested on larger monitors; everything appears to work! Hurray!