Add a sticky nav (+ misc nav improvements)

team178 / team178.github.io

The 2nd Law Enforcers' Website

http://farmingtonrobotics.org

Mozilla Public License 2.0

14 stars 17 forks source link

Add a sticky nav (+ misc nav improvements) #120

Closed TJScalzo closed 7 years ago

TJScalzo commented 7 years ago

I "solved" the sub-pixel rendering issue by making the text in the nav bar bolder. Other than that, I made the positioning and size of the external links bar more consistent. I did the same with the ENFORCERS logo thing.

I would merge this on my own, except I think it'd be a good idea to get feedback from the people who know more than me.

(#98)

TJScalzo commented 7 years ago

I could be mistaken, but these changes could also address problems brought up in #93? Maybe? I'm too tired to look through it all right now...

gluxon commented 7 years ago

This looks awesome from a quick look through. Give me until later tonight for the full review. 🙂

TJScalzo commented 7 years ago

Thank you very much Brandon! I'm happy you took the time to look my work over. I'll definitely look into CSS locks, they seem very useful.

TJScalzo commented 7 years ago

I'm going to say that these changes close issues #93 and #98. If anyone has objections feel free to reopen the issues.