search

team3130 / Robot-2014

The code for the 2014 robot
4 stars 0 forks source link

Thick subsystem #2

Closed kyraha closed 10 years ago

kyraha commented 10 years ago

A question. Is there a reason why the chassis does all the joystick's calculations to feed the numbers to the tank drive? In my opinion, it'd be better to put all the number crunching tasks into the Command code. Especially, for example, the part where the idle thresholds are checked. And let the Subsystem take care of its devices, with as much data (pre)processing as needed to control the hardware.

mattico commented 10 years ago

I agree. The Subsystems are supposed to be a direct abstraction of the hardware, and the example code is structured that way.

ashwinche commented 10 years ago

I was thinking along those same lines. I'm working on some PID code right now, and I did move the precision mode/deadzone code to the TankDrive command, but haven't committed anything yet. Feel free to do so yourselves.

On Mon, Jan 20, 2014 at 6:04 PM, Matthew Ickstadt notifications@github.comwrote:

I agree. The Subsystems are supposed to be a direct abstraction of the hardware, and the example code is structured that way.

— Reply to this email directly or view it on GitHubhttps://github.com/team3130/Robot-2014/issues/2#issuecomment-32809445 .

kyraha commented 10 years ago

Good collaboration motto for agile software development is: "Commit early, commit often." (Google it for details)