search

team3130 / Robot-2014

The code for the 2014 robot
4 stars 0 forks source link

Subsystem class Chassis has no destructor (potential memory leak) #3

Closed kyraha closed 10 years ago

kyraha commented 10 years ago

The constructor of Chassis class creates a bunch of "new" objects and assign their locations to corresponding pointers. But when the object ceases to exist the memory taken for those created objects might not get released implicitly. Someone please do a research and confirm this speculation, and fix this issue if needed. Thank you.

ashwinche commented 10 years ago

Quick Question: when a program is terminated (from the debugger), are the destructors of any objects called? I wouldn't think so; but a relatively painless way to check would be to printf something in the Chassis' destructor (or, actually, the CommandBasedRobot's constructor might be better) and see if something actually prints out. To do this, however, it would be necessary to enable NetConsole from the Imaging tool.

On Sun, Jan 26, 2014 at 8:40 PM, Mikhail Kyraha notifications@github.comwrote:

The constructor of Chassis class creates a bunch of "new" objects and assign their locations to corresponding pointers. But when the object ceases to exist the memory taken for those created objects might not get released implicitly. Someone please do a research and confirm this speculation, and fix this issue if needed. Thank you.

— Reply to this email directly or view it on GitHubhttps://github.com/team3130/Robot-2014/issues/3 .