Shooter

[minhnguyenbhs]

I'm not sure that further work on this would make the sim actually more meaningful without testing on the real robot, so could you review this and see what I should edit? Thank you!

[jkleiber]

For clarification on my above message: I think we should merge this PR when it's ready and then make a new PR for the work on integrating hardware on HITL

[minhnguyenbhs]

robotcontainer is currently absolutely melted will fix tonight or tomorrow morning

[minhnguyenbhs]

@aidnem hi!! sorry I forgot to request your review yesterday night- i think i should be done? possibly?

[aidnem]

@minhnguyenbhs no problem! I'm reading over the code but to be honest I'm not confident code reviewing yet so I'll ask Coach Justin tomorrow about it to get the workflow down. This could then be merged at the start of shop tomorrow, as I'll already have read over all the code.

One quick question: Did you resolve his comments on the previous review? I'm new to the review UI but it looks like some of his suggestions haven't been implemented (I could 100% just be reading wrong though).

[minhnguyenbhs]

@aidnem I think most of them should be done, although I might have missed something? oh I did remember specifically not fixing any of the build.gradle stuff because I thought that it would get fixed with the rebase, although that might have been a bad assumption- I'll check on that now haha

[jkleiber]

@aidnem how to be a code reviewer is in our docs here: https://team401.github.io/Docs/Programming/Software-Workflow.html#as-the-reviewer

Definitely feel free to add to this if you see me doing something that is worth adding to the list, or if you have additional ideas of how to be a good reviewer. It's possible this deserves its own page (and then we'd just link to that page from this section)