team4909 / 2019-Deep-Space

Team 4909's 2019 Robot Code
MIT License
2 stars 1 forks source link

Add a whenHeld to a custom trigger class #162

Open TechplexEngineer opened 5 years ago

TechplexEngineer commented 5 years ago

If/When they merge https://github.com/wpilibsuite/allwpilib/pull/1643 we can remove this shim

roshanr10 commented 5 years ago

if we're going to be doing this, why don't we inherit BionicTrigger from Trigger so they're more interchangeable? if your PR goes through, then it'll become native and no changes to be made

TechplexEngineer commented 5 years ago

@roshanr10 It would be good for someone to try to extend Trigger, but I was running into access issues. Please do try.