teamEightTO / polito-se2-23-08

Repository for the 01SQNOV - Software Engineering II course - Thesis Management project
GNU General Public License v3.0
0 stars 1 forks source link

TM-12 Archive Proposal - The Archived Proposal and All the Applications still Exist in the "Application" View for Professor #95

Closed s316741 closed 10 months ago

s316741 commented 10 months ago

image I have manually archived a proposal and the professor is still able to see the proposal and all the associated applications in the application tab.

s316741 commented 10 months ago

Steps to Reproduce the Error @lorenzobn:

lorenzobn commented 10 months ago

As far as the APPLICATION view for the professor is concerned, can you specify why it should be removed from the section? The problem is in the UI because, even if I can access the list of students who applied to a specific proposal, I should not see the buttons ACCEPT/REJECT. The backend is handling this:

image

s316741 commented 10 months ago

Okay so we should still see the application list but just without the buttons? and only the states Accepted/Rejected/Cancelled is that correct? @lorenzobn

lorenzobn commented 10 months ago

Okay so we should still see the application list but just without the buttons? and only the states Accepted/Rejected/Cancelled is that correct? @lorenzobn

Yes. For the student view I am working on it.

s316741 commented 10 months ago

Thanks, @lorenzobn I think removing the buttons once the application is accepted/rejected will resolve this issue.

lorenzobn commented 10 months ago

Backend side is fixed for student now.

s316741 commented 10 months ago

@lorenzobn the archived proposal exists in Student View as well. If you archive the proposal this still exists in the student view

s316741 commented 10 months ago

@lorenzobn opened another issue as I reported. https://github.com/teamEightTO/polito-se2-23-08/issues/101

lorenzobn commented 10 months ago

Archived, on my side, shows cancelled proposal. So I assume it is fixed. We need to fix the frontend with the buttons to fix and close the issue.

s316741 commented 10 months ago

@RiccardoVukovic320029 need help here