search

teamatldocker / jira

Dockerized Atlassian Jira
https://hub.docker.com/r/teamatldocker/jira/
MIT License
437 stars 223 forks source link

Unable to set multiple parameters for variables in setenv.sh using SETENV prefix #139

Closed Numner closed 4 years ago

Numner commented 4 years ago

Came across an issue while trying to change the JVM_CODE_CACHE_ARGS variable in the setenv.sh file. I was trying to change the value's two parameters, but found that only the first parameter was grabbed.

JVM_CODE_CACHE_ARGS='-XX:InitialCodeCacheSize=32m -XX:ReservedCodeCacheSize=512m'

Seems that whenever the value is passed in this function, since it's not quoted it only grabs the first value if there are spaces.

https://github.com/teamatldocker/jira/blob/bdbc2bbe2124468a59de59121ca740835fc58cb8/bin/docker-entrypoint.sh#L36

Adding double quotes to that line fixes it, but I'm curious if there's a more official way to change that setting.