teambank / easycredit-plugin-magento-2

Plugin for webshop magento 2
4 stars 1 forks source link

Magento default "Ship order" is not going to report the delivery to easyCredit #13

Closed p24-max closed 1 year ago

p24-max commented 1 year ago

Once an order is shipped, our ERP system reports this information to magento2 using REST shipment api. From magento, the shipment information should then be automatically carried to the payment provider (easyCredit).

This is not working with this easyCredit module as it looks like it does not follow the magento shipment standard. When I do create a shipment (magento default) for an order, easyCredit module is not respecting this. Instead, a custom "report delivery" feature was added by this module which requires manual interaction.

Please wire the magento default order-shipment with the easyCredit report shipment functionality.

netzkollektiv commented 1 year ago

The shipment is automatically being sent with the capture action, see here: https://github.com/teambank/ratenkaufbyeasycredit-plugin-magento-2/blob/4e6e71be349ab3662b29ff78968336ef7d5e7369/Model/Payment.php#L232

This means once you create the invoice for an order the shipment is reported to easyCredit. If this does not suit your workflow you may overwrite the payment model and move the implementation to another action or build a custom observer.

The widget for manual sending is a convenience functionality for merchants who are not using the Magento invoice / shipment system.