Issue on AWS Code Deploy with symlink in docs/ (sphinx_rtd_theme)

teambank / easycredit-plugin-magento-2

Plugin for webshop magento 2

4 stars 1 forks source link

Issue on AWS Code Deploy with symlink in docs/ (sphinx_rtd_theme) #14

Closed MTheProgrammer closed 1 year ago

MTheProgrammer commented 1 year ago

Hello,

CodeDeploy on AWS fails because of this symlink file that points to not existing target: sphinx_rtd_theme

Is it really necessary for the docs to be in the same repository as the Magento module? This has impact on our deployment pipeline.

netzkollektiv commented 1 year ago

Thanks you for creating the issue. This seems to be a very specific case to me. You may just delete the symlink or the whole directory.

MTheProgrammer commented 1 year ago

I'm installing it with composer. I believe that packages pushed to the Packagist repository should contain only the code that is used by the module to reduce download size.

Is it a lot of work from your side to skip the docs directory before publishing it to the registry?

netzkollektiv commented 1 year ago

Can you please provide a minimal example how to reproduce the error?