search

teambit / bit.envs

DEPRECATED - Bit compilers and testers were moved to https://github.com/teambit/envs
https://bit.dev/bit/envs
Other
23 stars 9 forks source link

ts compiler - copy assets / non compiled files to dist folder #48

Closed GiladShoham closed 4 years ago

GiladShoham commented 4 years ago

I think it's always better to copy files the compiler doesn't know how to handle as is to the dist files. Most of the compilers already do this. This will prevent bugs arrised from accessing assets files of the component for example (since they won't exist in the dist folder of the component).

qballer commented 4 years ago

fixed in 3.0.16

fabgallo commented 4 years ago

@qballer what about the react-typescript compiler (which was at version v3.0.17)? Is v3.0.19 the one with the fix?

GiladShoham commented 4 years ago

@fabgallo From looking on the dependencies tab of react-typescript 3.0.19 it seems that it uses typescript 3.0.16 so it should be fine.

fabgallo commented 4 years ago

@GiladShoham unfortunately it seems not image

The compiler is the only thing I changed (bit import bit.envs/compilers/react-typescript -c). If I change the version back to 3.0.1 in bit.json it works (even if I use 3.0.17 it compiles no problem, apart for missing the SCSS files).

Update: I just saw the typescript compiler has been updated to 3.0.20, so I guess a new react-typescript one is on the way...?

GiladShoham commented 4 years ago

@fabgallo Thanks for reporting this. Looks like some typo in the code. I'll ask @qballer to take a look. Can you open it as a new issue since it's not really related to the copy files issue? Thanks.

fabgallo commented 4 years ago

Will do soon.

Update: here it is