search

teambit / bvm

Bit version manager
Other
42 stars 13 forks source link

Missing license information #18

Closed nj314 closed 3 years ago

nj314 commented 3 years ago

All published npm packages from this repo are currently missing LICENSE information. This means certain organizations cannot use bvm because they cannot verify that the license permits their usage.

The following packages are missing license info:

GiladShoham commented 3 years ago

That's right, I'll make sure they have a license. Thanks.

ChazUK commented 3 years ago

Hi @GiladShoham, is there any update on this. My organisation has asked me to look into integrating Bit into our workflow, but unfortunately I'm stumped on the first hurdle.

GiladShoham commented 3 years ago

Fixed. See - https://github.com/teambit/bvm/commit/5c930df140f9372d20f6e1b7486afac85ec1945e

ChazUK commented 3 years ago

Thanks @GiladShoham can you confirm that these changes have been published to npm?

GiladShoham commented 3 years ago

not yet, I'll take care of this soon

GiladShoham commented 3 years ago

done

ChazUK commented 3 years ago

Hi @GiladShoham unfortunately our Nexus repository is still complaining

@teambit/time.time-format@0.0.298:SEE,LICENSE,IN,LICENSE @teambit/network.proxy-agent@0.0.90:SEE,LICENSE,IN,LICENSE @teambit/network.agent@0.0.90:SEE,LICENSE,IN,LICENSE

I can also see @teambit/toolbox.time-format uses the same SEE LICENSE entry

Maybe these /toolbox packages have been deprecated?

I've had a few issues with other libraries and their dependencies giving these errors, so I'm going to make a full list of all the @teambit/ scoped packages which have this license issue and put it in my next comment.

GiladShoham commented 3 years ago

about these 

@teambit/time.time-format@0.0.298:SEE,LICENSE,IN,LICENSE
@teambit/network.proxy-agent@0.0.90:SEE,LICENSE,IN,LICENSE
@teambit/network.agent@0.0.90:SEE,LICENSE,IN,LICENSE

It's just about upgrading the versions used by bvm. I'll take care of this soon.

About the longer list, those are not used by bvm, they are used by bit itself. Did you check bvm only or bit as well?

ChazUK commented 3 years ago

Is there a way to install bit without bvm? Currently we are unable to get past that first step

ChazUK commented 3 years ago

Also I'd like to thank yourself and @davidfirst for taking the time to do this! I can imagine it was not an easy job, and that there's a picture of my git profile picture on a dartboard in the office 😂

GiladShoham commented 3 years ago

update all the relevant packages to be the ones with the license. Let me know if there are still missing licenses (or I can close this issue).

Also added a new "use" command which lets you switch easily between bit versions. image

Is there a way to install bit without bvm? Currently we are unable to get past that first step

You can in general just install it with npm i -g @teambit/bit but I recommend using bvm. that's way you can control the bin name. you can switch between versions. you can easily upgrade. you can use more than one version at the same time. and more.

Also I'd like to thank yourself and @davidfirst for taking the time to do this! I can imagine it was not an easy job, and that there's a picture of my git profile picture on a dartboard in the office 😂

You are welcome:) We are here to help.

ChazUK commented 3 years ago

@GiladShoham npm i -g @teambit/bvm now works on our internal systems after being installed via Nexus!

But I'm now seeing some another error with bvm install. I'm currently in the process of talking to our it/network guy as we're getting a timeout error

request to https://storage.googleapis.com/storage/v1/b/bvm.bit.dev/o?prefix=versions/dev/Darwin/ failed, reason: connect ETIMEDOUT 172.217.168.208:443
GiladShoham commented 3 years ago

Seems like a network issue indeed. In case you will need to configure proxy to access this URL, let me know and I'll guide you about setting the proxy for bvm.

mitchdotdeveloper commented 3 years ago

Hey @GiladShoham! I had the same problem as @ChazUK. However I was able to set the proxy, but now it isn't finding my local issuer certificate which I have set up for npm. How do I go about getting bvm to use it?

Screen Shot 2021-10-27 at 9 57 55 AM

Also, I looked through the bvm code base and found 'proxy.ca' and 'proxy.cert' as possible config values and I set them to the file path of my ca-certs.pem file to no avail.

ChazUK commented 3 years ago

@GiladShoham Also if you have a guide for setting up the proxy that would be very helpful.

mitchdotdeveloper commented 3 years ago

@GiladShoham Also if you have a guide for setting up the proxy that would be very helpful.

I went to https://harmony-docs.bit.dev/aspects/dependency-resolver/#set-a-proxy-for-outgoing-httphttps-requests and instead of bit config set proxy ... I just did bvm config set proxy

johnschult commented 2 years ago

@mitchdotdeveloper If you already have npm or yarn proxies configure then you don't need to do it for bvm or bit. According the bit docs, they use the configured proxy settings from npm. However, even when they are set correctly, the command bvm install still errors out with:

request to https://storage.googleapis.com/storage/v1/b/bvm.bit.dev/o?prefix=versions/dev/Darwin/ failed, reason: unable to get local issuer certificate

This does not indicate that the proxy is not set, it is saying that the certificate chain does not include the one used for the proxy. When you said something about proxy.ca and proxy.cert you were on to something, but wven with those set it doesn't work. Clearly something is not using those settings.

GiladShoham commented 2 years ago

@ChazUK @johnschult @mitchdotdeveloper Thanks for your comments. I really recommend opening a new issue about these issues. as it's definitely not related to the original issue. Also, this issue is closed, so higher chance people will miss these comments as opposed to new open issues. Once you will open new one, I'll comment there :)

johnschult commented 2 years ago

Yeah I noticed that yesterday. I was checking into how node-fetch was getting used. I'll open an issue today.