teambition / gulp-ssh

SSH and SFTP tasks for gulp
184 stars 38 forks source link

shell seems doesn't callback #42

Closed soonlive closed 8 years ago

soonlive commented 8 years ago

hi @zensh ,

I'm using gulp-ssh to exec a shell in order to unarchive files. But it seems doesn't work correctly.

As you can see, it just pause there image

and the following is my config: image

Could you figure out how to make it work?

zensh commented 8 years ago

did the command ran in remote?

soonlive commented 8 years ago

yep, it did

mickaelperrin commented 8 years ago

Hi, @soonlive regarding your code, I am maybe wrong but it seems your lacking a returnstatement at the beginning of the testSSH line ?

However, @zensh I encounter a similar problem when using gulp-ssh as an external module with a modular gulp approach.

I have created a specific repository https://github.com/mickaelperrin/gulp-ssh-error to give you a way to reproduce the error.

See the README in my repository for additionnal informations on how to run the test and the problem I encounter.

Just added a pull request also, that seems to correct the issue, but I don't know if it can break something elsewhere.

Hope it helps.

zensh commented 8 years ago

@mickaelperrin Thank you for your PR. It happened because of using different gulp instance.

mickaelperrin commented 8 years ago

Thanks for taking time to explore my problem.

I just gave a try to the new release 0.5.6, but didn't notify any changes in the behaviour.

Would you mind taking a look at the update my demo, to see what's wrong with my code ?

mickaelperrin commented 8 years ago

Mmm, got it new gulp option is not a suboption of sshConfig. Sorry for busying you with that.