Be more careful parsing local times in rules - Githubissues

teambition / rrule-go

Go library for working with recurrence rules for calendar dates.

MIT License

310 stars 57 forks source link

Be more careful parsing local times in rules #19

Closed egorbunov closed 5 years ago

egorbunov commented 5 years ago

Hello!

This patch makes package a little bit more flexible in parsing rrule sets including local times. For example in RDATE/EXDATE, as RFC5545 states, there may be no time zone info to parse date time in.

That seems to impossible to implement floating time using standard go time structure. So that is handy to make it possible for user to specify in which location such times are parsed by default. Also it is natural to use DTSART time zone as a fallback for RDATE/EXDATE local time dates.

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 99.088% when pulling d4eb8200e532413bcdf4ed5239dfdea11ea85175 on egorbunov:master into a1ff18dc879b8f3376e3f08cd96f65ab0a4817bc on teambition:master.

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 99.088% when pulling d4eb8200e532413bcdf4ed5239dfdea11ea85175 on egorbunov:master into a1ff18dc879b8f3376e3f08cd96f65ab0a4817bc on teambition:master.

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 99.088% when pulling d4eb8200e532413bcdf4ed5239dfdea11ea85175 on egorbunov:master into a1ff18dc879b8f3376e3f08cd96f65ab0a4817bc on teambition:master.

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 99.088% when pulling d4eb8200e532413bcdf4ed5239dfdea11ea85175 on egorbunov:master into a1ff18dc879b8f3376e3f08cd96f65ab0a4817bc on teambition:master.

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 99.088% when pulling d4eb8200e532413bcdf4ed5239dfdea11ea85175 on egorbunov:master into a1ff18dc879b8f3376e3f08cd96f65ab0a4817bc on teambition:master.

coveralls commented 5 years ago

Coverage increased (+0.4%) to 99.634% when pulling 655c1464374c01ebb2b95aba761350ce7b759bad on egorbunov:master into a1ff18dc879b8f3376e3f08cd96f65ab0a4817bc on teambition:master.

egorbunov commented 5 years ago

@rickywiens, if you are still interested, please, check my additions