Output DTSTART correctly for RFC

rickywiens commented 5 years ago

I was not outputting the RRULE correctly when RFC compatibility was set for DTSTART. According to the spec there should be a semi-colon iff there is a TZID attribute on the DTSTART key. Iff there is no TZID param after the DTSTART key, there should be a colon, followed by the value of the DTSTART key.

eg.

DTSTART;TZID=America/New_York:20180101T090000 - correct DTSTART:20180101T090000Z - correct DTSTART:TZID=America/New_York:20180101T090000 - not correct

This was causing issues passing the RRULE strings around between different RRULE libraries (PHP/JS versions of RRULE libraries)

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 99.468% when pulling c8ee0cbc9f8267780f4a3138907e9cb4800b9c41 on rickywiens:rw/dtstart-rfc-fix into bf32e568ec7112efe981ea1983050ae3f6e45521 on teambition:master.

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 99.468% when pulling c8ee0cbc9f8267780f4a3138907e9cb4800b9c41 on rickywiens:rw/dtstart-rfc-fix into bf32e568ec7112efe981ea1983050ae3f6e45521 on teambition:master.

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 99.468% when pulling c8ee0cbc9f8267780f4a3138907e9cb4800b9c41 on rickywiens:rw/dtstart-rfc-fix into bf32e568ec7112efe981ea1983050ae3f6e45521 on teambition:master.

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 99.468% when pulling c8ee0cbc9f8267780f4a3138907e9cb4800b9c41 on rickywiens:rw/dtstart-rfc-fix into bf32e568ec7112efe981ea1983050ae3f6e45521 on teambition:master.

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 99.468% when pulling c8ee0cbc9f8267780f4a3138907e9cb4800b9c41 on rickywiens:rw/dtstart-rfc-fix into bf32e568ec7112efe981ea1983050ae3f6e45521 on teambition:master.

coveralls commented 5 years ago

Coverage decreased (-0.2%) to 99.468% when pulling c8ee0cbc9f8267780f4a3138907e9cb4800b9c41 on rickywiens:rw/dtstart-rfc-fix into bf32e568ec7112efe981ea1983050ae3f6e45521 on teambition:master.

coveralls commented 5 years ago

Coverage increased (+0.001%) to 99.645% when pulling 73dcda74af769eaabdaa1f0d2659d4ada823a058 on rickywiens:rw/dtstart-rfc-fix into bf32e568ec7112efe981ea1983050ae3f6e45521 on teambition:master.

rickywiens commented 5 years ago

@egorbunov if you have some time please take a look at this. Relevant portion of the RFC is Page 27 and Page 33-34.

https://tools.ietf.org/html/rfc5545

egorbunov commented 5 years ago

@rickywiens, I agree with your patch, thanks :+1:

rickywiens commented 5 years ago

Any possibility of getting this in this week? @zensh

zensh commented 5 years ago

@rickywiens Thank you. v1.4.0 released.

teambition / rrule-go

Output DTSTART correctly for RFC #29