Element detail modal improvements

teambtcmap / btcmap-ios

iOS application for BTC Map

https://btcmap.org

GNU Affero General Public License v3.0

14 stars 3 forks source link

Element detail modal improvements #11

Closed lorenzoPrimi closed 1 year ago

lorenzoPrimi commented 1 year ago

[ ] Finish adding rows to match Android. For sure Instagram and Pouch, need to verify what else
[x] Phone number parsing isn't working for all formats. Can mimic Android repo implementation
[ ] Hide tags initially. Tags button shows/hides.
[x] Change "Verify" button to "Verify or Report" to match android

salvatoto commented 1 year ago

@lorenzoPrimi

"Finish adding rows to match Android. For sure Instagram and Pouch, need to verify what else" ^ This goes along with the missing contact buttons on the Community Detail screen. Just missing contact links here as well
This you fixed
Android has the tags dump hidden initially and you can turn them on in Settings. I just implemented on by default. I do like on by default after implementing better styling. We could implement a settings switch to turn off (would require starting a Settings screen first!)
Still says just "Verify", Android says "Verify or Report"

lorenzoPrimi commented 1 year ago

For the 4, it is a quick fix, but you might want to have a look at https://github.com/teambtcmap/btcmap-ios/issues/6 to keep in sync iOS and android

lorenzoPrimi commented 1 year ago

Working on this, I have a question about (1) Why does the "Verify" button, changes into "Pay" when there is a Pouch link? https://github.com/teambtcmap/btcmap-ios/issues/21 There is no need to verify anymore? Is this the right logic?

Moving (3) in a separate issue https://github.com/teambtcmap/btcmap-ios/issues/23

salvatoto commented 1 year ago

Why does the "Verify" button, changes into "Pay" when there is a Pouch link? #21

Honestly I don't know. Just saw that on the android app recently. But missed the conversation on it