search

teambtcmap / btcmap-ios

iOS application for BTC Map
https://btcmap.org
GNU Affero General Public License v3.0
14 stars 3 forks source link

Simple apple maps implementation #9

Closed lorenzoPrimi closed 1 year ago

lorenzoPrimi commented 1 year ago

At the moment I allow the user to tap on the address and be able to open Apple maps, I still want to add the possibility to choose from different map apps.

lorenzoPrimi commented 1 year ago

Hi @salvatoto, I started adding some code to open various map apps (not just apple maps) but this will require opening a modal and change a bit the logic of the return in this code.

Should we merge this first and then work on the multiple maps choice?

salvatoto commented 1 year ago

Hi @salvatoto, I started adding some code to open various map apps (not just apple maps) but this will require opening a modal and change a bit the logic of the return in this code.

Should we merge this first and then work on the multiple maps choice?

I'll leave it up to you how you want to do it. I'm going to release a v1.1.1 this weekend as we have to change the donation links, so we can merge this now if you want it in there.

lorenzoPrimi commented 1 year ago

Thanks, so please review this one as it is so we have a new feature in the v1.1.1. I'll add support for Google Maps and other maps apps in subsequent PR.