teambtcmap / btcmap.org

Free and open source bitcoin map web application
https://btcmap.org
GNU Affero General Public License v3.0
43 stars 11 forks source link

Use preferred tile.openstreetmap.org URL #114

Closed danieldegroot2 closed 10 months ago

danieldegroot2 commented 10 months ago

I would like to suggest using the now preferred https://tile.openstreetmap.org URL instead of the current one ({s}), see

https://github.com/openstreetmap/operations/issues/737

netlify[bot] commented 10 months ago

Deploy Preview for btcmap ready!

Name Link
Latest commit 637a79e912abbcb450da933b8bd6fca76216e3bb
Latest deploy log https://app.netlify.com/sites/btcmap/deploys/65624f77b3f46a0008b6a9d5
Deploy Preview https://deploy-preview-114--btcmap.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

secondl1ght commented 10 months ago

Hi thanks for the PR! I was not aware of this change so thanks for sharing. There are other URLs in the code that also need to be updated, would you like to add those as well to this PR?

danieldegroot2 commented 10 months ago

This is the only URL for tile.openstreetmap.org as far as I can see. (noteably openstreetmap.org, not opentopomap, .de etc., those are different providers) Otherwise, please provide a link to to the line in the code which needs to be changed.

If there is anything else which needs to be changed (elsewhere this was not the case), then it may be best to check each provider / file manually and change this yourself. This also applies to any other service and attribution. (note I am not a developer, I just change the URL where possible)

secondl1ght commented 10 months ago

Ah ok you are right, I didn't notice in that discussion thread you linked but yes it seems it is only for the .org domain. Merging now!