search

teambtcmap / btcmap.org

Free and open source bitcoin map web application
https://btcmap.org
GNU Affero General Public License v3.0
41 stars 11 forks source link

feat: link map image #128

Closed escapedcat closed 4 months ago

escapedcat commented 4 months ago

Does this PR address a related issue? No

A description of the changes proposed in the pull request I tend to click on the map image to go to the map on desktop.
Maybe I'm the only one. Just wanted to propose it.

netlify[bot] commented 4 months ago

Deploy Preview for btcmap ready!

Name Link
Latest commit a8fabf6750e428ebd2871ee63478da242e695ea6
Latest deploy log https://app.netlify.com/sites/btcmap/deploys/65d4a02a95d29a00084f264d
Deploy Preview https://deploy-preview-128--btcmap.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 55 (🟢 up 1 from production)
Accessibility: 84 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 100 (no change from production)
PWA: 90 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

secondl1ght commented 4 months ago

Hey @escapedcat good to hear from you. :) I don't see an issue with this, the only thing might be that we would not want to have this a link on mobile to avoid users accidentally clicking on it while scrolling the page. But I think it's fine, and we can make that update later if anyone complains about this. Thanks for the PR!

escapedcat commented 4 months ago

Let me know if this is causing issues. Happy to adjust this. Thanks for btcmap, really helpful!