search

teambtcmap / btcmap.org

Free and open source bitcoin map web application
https://btcmap.org
GNU Affero General Public License v3.0
41 stars 11 forks source link

Add help links #131

Closed bubelov closed 3 months ago

bubelov commented 3 months ago

Does this PR address a related issue?

A description of the changes proposed in the pull request

Screenshots

Additional context

netlify[bot] commented 3 months ago

Deploy Preview for btcmap ready!

Name Link
Latest commit 7ea6412967ddc6f6301005c9072418ca526cf988
Latest deploy log https://app.netlify.com/sites/btcmap/deploys/65f3c5766d4b6c0007c46f03
Deploy Preview https://deploy-preview-131--btcmap.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 44 (🔴 down 1 from production)
Accessibility: 84 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 100 (no change from production)
PWA: 90 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

secondl1ght commented 3 months ago

I was thinking we could just turn the description ex. 'Outdated location' into a link that leads to the Wiki. What do you think? Is it better to have a dedicated column?

bubelov commented 3 months ago

I'm not sure if the description field is necessary since we have a type field. It would be stupid to send 100+ descriptions when we'll need to localize the app, and it's not good for sync and local storage

bubelov commented 3 months ago

So, the description column can be removed in the future, or it can be derived from the type field client-side. As for the link, I don't really care, but it's better if we put something actionable there as soon as possible

secondl1ght commented 3 months ago

This is a good idea about deriving the descriptions from the types on the client-side. Just let me know when you want to deprecate that field in the backend and I will make the updates on the frontend.