search

teambtcmap / btcmap.org

Free and open source bitcoin map web application
https://btcmap.org
GNU Affero General Public License v3.0
41 stars 11 forks source link

Third party payment app hides native payment method #139

Closed VojtechMyslivec closed 2 months ago

VojtechMyslivec commented 2 months ago

Describe the bug When a merchant accepts both native payment method (e.g. via lightning) and third party app, only "third party app" icon is shown.

To Reproduce See e.g. Pivovarský klub Benedict or Café Decada. Both places accept bitcoin directly via lightning and the payment:lightning=yes tag is set. The latter accepts bolt cards as well (payment:lightning_contactless=yes). However, neither "lightning accepted" nor "contactless accepted" icons are shown.

Expected behavior "lightning accepted", "contactless accepted" etc icons are shown when appropriate tags are set even if third party app is possible (but not required).

Screenshots Screenshot from 2024-04-11 10-08-58 Screenshot from 2024-04-11 10-11-44

Additional context

secondl1ght commented 2 months ago

Hi @VojtechMyslivec, yes you are correct about this. The Querko? team started using a new tag called payment:lightning:requires_companion_app which indicates that a third party app is required. So this tag should be removed if the merchant accepts native lightning. However, because it seems like this dataset is very likely to go unmaintained by the owners I will make an adjustment. If any native bitcoin options are present then we can ignore this outdated tag. Thanks!