Closed dadofsambonzuki closed 1 year ago
Looks like `payment:blah=no' doesn't remove or strike-out that payment type.
e.g. https://www.btcmap.org/map?lat=11.9675153&long=121.9274626
Yes I didn't add that functionality because we don't mention adding those tags in the Wiki: https://github.com/teambtcmap/btcmap.org/wiki/Tagging-Instructions
Do you think people would explicitly add a no
tag?
I'll update the Tagging Instructions.
We've already had feedback that this would be useful.
Sounds good - will do
@cogentgene could you send me strike-out versions of static/icons/ln.svg
, static/icons/btc.svg
and static/icons/nfc-map.svg
please?
Hover overs should be explicit too for accepted, unknown, not accepted.
e.g. 'On-chain accepted', 'On-chain unknown', 'On-chain not accepted'.
@dadofsambonzuki are you happy with the way it is now or does this still need improvement?
Strikethrough assets still required.
Paging @cogentgene - How do we feel about strikethroughs?
Hey, added them! Check out the Figma file. PS. if I don't respond within a few days, DM me directly in Discord and or Slack or Twitter. @dadofsambonzuki @secondl1ght
I just miss these notifications easily :( I guess being bombarded by all sorts just made me immune to checking them lol
They are beautiful Gene.
There was talk about the onchain one being a chain. Where do you stand on that? I think I prefer the Bitcoin, although I get the logical argument against.
On Fri, 30 Sept 2022 at 12:12, Gene @.***> wrote:
Hey, added them! Check out the Figma file. PS. if I don't respond within a few days, DM me directly in Discord and or Slack or Twitter.
I just miss these notifications easily :( I guess being bombarded by all sorts just made me immune to checking them lol
[image: Image] https://user-images.githubusercontent.com/3827304/193257462-2d176098-beaa-427f-aba6-7eed9a2959c1.jpg
— Reply to this email directly, view it on GitHub https://github.com/teambtcmap/btcmap.org/issues/15#issuecomment-1263440380, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUYWY7KXWIAVSYNWQBVBEE3WA3DIJANCNFSM6AAAAAAQQE4GEE . You are receiving this because you were mentioned.Message ID: @.***>
@dadofsambonzuki I think I prefer the standard Bitcoin icon ₿. Chain could be mistaken for a link. I think it fairly accepted that Bitcoin symbol ₿ can mean on-chain AND lightning, UNLESS lightning is specifically mentioned with a bolt icon ⚡️ - in which case it becomes clear ₿ means on-chain. I hope..
Agreed.
Thanks guys - this is complete now
Without any specific payment tags (i.e. just
currency:XBT=yes
orpayment:bitcoin=yes
) we should show all three icons (bitcoin/on-chain, lightning and contactless bars) greyed out.We colour them when we have a specific
payment:blah=yes
tag and we strike them out if we see a 'payment:blah=no' tag.