search

teambtcmap / btcmap.org

Free and open source bitcoin map web application
https://btcmap.org
GNU Affero General Public License v3.0
41 stars 10 forks source link

Filter locations by payment type - Web App #20

Closed dadofsambonzuki closed 1 year ago

dadofsambonzuki commented 1 year ago

On-chain Lightning Lightning Contactless

secondl1ght commented 1 year ago

This functionality is currently available using URL query params, did we also want to add buttons to the map? I think @bubelov mentioned that we might not want to implement this right now because lots of the tags are not accurate so the filtering will not be accurate either and might confuse people or cause them to miss businesses that do accept a payment method. If we decide not to do anything further with this right now lets close this issue and put a reminder task in the backlog for later.

dadofsambonzuki commented 1 year ago

Fair point re data quality. We see this in the dashboard where individual payment methods don't add to the total.

Let's close for now.

secondl1ght commented 1 year ago

Fair point re data quality. We see this in the dashboard where individual payment methods don't add to the total.

Let's close for now.

Yeah I also noticed that on the dashboard, but in that location it might be OK to leave it? Was thinking maybe we could have some info tooltips there explaining what tags each one is?

yanascz commented 7 months ago

Any ETA when this might be added as a filtering option? Modification of URL is possible but it's pretty user-unfriendly. Is it worth filing a feature request for that?

secondl1ght commented 7 months ago

Hi @yanascz the payment tags are not as widely used as the base bitcoin tags so you would be missing out on merchants if you applied these filters. I think it's safe to assume that almost 100% of merchants accepting bitcoin are probably going to accept lightning if that is the filter you are trying to apply.

yanascz commented 7 months ago

I understand your point but in light of https://github.com/teambtcmap/btcmap.org/pull/110, it'd be really great to filter out merchants accepting BTC via a 3rd party app (or vice versa). Our Czech community put a lot of effort into cleaning the data set so it'd work pretty well in Czechia, I hope.

secondl1ght commented 7 months ago

I think adding a filter for those third party required locations makes sense, it could be added when the third party icon gets added.

yanascz commented 7 months ago

Great! Do you want me to file a follow-up feature request?

secondl1ght commented 7 months ago

Sure it couldn't hurt for tracking purposes, thanks!