search

teambtcmap / btcmap.org

Free and open source bitcoin map web application
https://btcmap.org
GNU Affero General Public License v3.0
41 stars 10 forks source link

Map edit button broken #41

Closed dadofsambonzuki closed 1 year ago

dadofsambonzuki commented 1 year ago

The OSM edit link in the edit icon on the location bubble are not connected to the correct OSM node IDs.

secondl1ght commented 1 year ago

@dadofsambonzuki I checked a couple and they are working for me, can you send me a location that is broken please?

dadofsambonzuki commented 1 year ago

It seems to be a Node vs Way thing.

If it is a Way it has a different edit URL. We currently send editors to the Node with that ID, not the Way with that ID.

The edit URL needs to be different for Nodes and Ways.

Example:

https://btcmap.org/map?lat=51.45791535&long=-0.3048932

Opens https://www.openstreetmap.org/edit?node=432808200 and not https://www.openstreetmap.org/edit?way=432808200#map=19/51.45792/-0.30489.

secondl1ght commented 1 year ago

Ok thanks will fix.

secondl1ght commented 1 year ago

Fixed I also added the relation type - @dadofsambonzuki