search

teambtcmap / btcmap.org

Free and open source bitcoin map web application
https://btcmap.org
GNU Affero General Public License v3.0
41 stars 11 forks source link

Communities with `null` icon do not show #83

Closed dadofsambonzuki closed 1 year ago

dadofsambonzuki commented 1 year ago

Describe the bug

Communities with a null icon:square value are not displayed on the web app.

To Reproduce

Create a community with a null icon.

Expected behavior

The same as a community without an icon:square value. i.e. show the community with the default bitcoin icon.

Screenshots

Additional context

https://github.com/teambtcmap/btcmap-data/issues/3252

secondl1ght commented 1 year ago

This isn't a bug it's on purpose - we want each community to have an icon.

dadofsambonzuki commented 1 year ago

But we do show a default icon when there isn't an icon tag present, right?

On Mon, 17 Apr 2023, 16:49 secondl1ght, @.***> wrote:

This isn't a bug it's on purpose - we want each community to have an icon.

— Reply to this email directly, view it on GitHub https://github.com/teambtcmap/btcmap.org/issues/83#issuecomment-1511631477, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUYWY7IEUCWJ6XPIKD7UHBTXBVRAHANCNFSM6AAAAAAXA3XEPI . You are receiving this because you authored the thread.Message ID: @.***>

secondl1ght commented 1 year ago

No when there is no icon tag present it doesn't pass the validation check and will not be displayed - the default icon is a fallback that gets shown if the URL to the icon tag is broken. Which shouldn't be the case for most communities since we self-host the assets, but there are a few orgs that decided to host their own and in some cases have since broken the URLs.

dadofsambonzuki commented 1 year ago

Ah, OK - got it!

On Mon, 17 Apr 2023 at 21:04, secondl1ght @.***> wrote:

No when there is no icon tag present it doesn't pass the validation check and will not be displayed - the default icon is a fallback that gets shown if the URL to the icon tag is broken. Which shouldn't be the case for most communities since we self-host the assets, but there are a few orgs that decided to host their own and in some cases have since broken the URLs.

— Reply to this email directly, view it on GitHub https://github.com/teambtcmap/btcmap.org/issues/83#issuecomment-1512008489, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUYWY7KYRKZQ5GQRGJZKSO3XBWO6NANCNFSM6AAAAAAXA3XEPI . You are receiving this because you authored the thread.Message ID: @.***>