teamcfadvance / CFSelenium

A native Selenium WebDriver binding for ColdFusion
Apache License 2.0
81 stars 32 forks source link

Change to how timeout is determined for waitForElement functions. #10

Closed cfoutlaw closed 12 years ago

cfoutlaw commented 12 years ago

Made changes to waitForElementPresent, waitForElementVisible, and waitForElementNotVisible. Changed the timeout to use getTickCount() to determine when the timeout has expired. The way this was working was not taking into account the time the request to selenium server was using.

bobsilverberg commented 12 years ago

Thanks for the pull request, Michael. Sorry it took me so long to address it.

cfoutlaw commented 12 years ago

No problem. Thank you for accepting the change. This marks a milestone for me as my first contribution to an open source project.

bobsilverberg commented 12 years ago

Excellent! Congratulations, and may there be many more. :-)