search

teamcfadvance / CFSelenium

A native Selenium WebDriver binding for ColdFusion
Apache License 2.0
81 stars 32 forks source link

Should waitForPageToLoad() and waitForFrameToLoad() timeouts default to variables.waitTimeout? #17

Closed adrianblynch closed 9 years ago

adrianblynch commented 10 years ago

I've tweaked the arguments to these two methods so they default to variables.waitTimeout to save on having to do selenium.waitForPageToLoad(myWaitValue).

Any reason not to do this?

DannyCork commented 10 years ago

Not that I can see.

adrianblynch commented 9 years ago

Looks like this was accepted: https://github.com/teamcfadvance/CFSelenium/commit/366d7b39ced7fb90c068502db8ac6cce8e274a7a