teamcfadvance / CFSelenium

A native Selenium WebDriver binding for ColdFusion
Apache License 2.0
81 stars 32 forks source link

File Name Disambiguation; Implement WebDriverManager; Modernize Readme. #27

Closed jamiejackson closed 8 years ago

jamiejackson commented 8 years ago

@Lampei, I could use a review, if you get a chance.

Additions

Implemented WebDriver Manager

After Firefox upgraded to v47 the other day and broke CFSelenium's brand-new WebDriver support for Firefox, I realized that the way we're managing driver binaries (manually, and in SCM) is brittle. (http://stackoverflow.com/a/37728659)

WebDriverManager manages those binaries, and that library has been implemented in this pull request. Driver binaries have been removed from the repo.

To Discuss

At the moment, I'm allowing the driver repository path be set like this:

selenium = new SeleniumWebDriver(driverType="firefox", defaultLocalDriverRepoPath="/your/custom/path");

...which, behind the scenes, sets a Java system property (wdm.targetPath) that WebDriverManager uses as the path to the repository (for downloaded drivers).

I think maybe I'd prefer if we just used the JVM property directly, and had users do createObject("java", "java.lang.System").setProperty("wdm.targetPath", "/custom/path/") if they want to have a custom repository location.

Thoughts?

Disambiguated Classes

For example:

Side note: Did those renames work out properly? I wanted to preserve history, so I did a rename rather than copy-paste of content, but the changes don't seem to reflect it.

Reworked readme.md in light of recent changes.