search

teamcfadvance / ValidateThis

An object oriented validation framework for ColdFusion objects
http://www.validatethis.org
44 stars 32 forks source link

OPEN - task 50: Performance issues w/jQuery generated code #58

Closed aliaspooryorik closed 13 years ago

aliaspooryorik commented 13 years ago

Hi Bob, I've reduced the amount of JavaScript and also slightly improved performance by reusing selectors. Works on everything apart from IE 5.5 or less.

http://github.com/https://github.com/ValidateThis/ValidateThis/issues/issue/50

bobsilverberg commented 13 years ago

Everything looks great, John, except that one Selenium test is failing. The test is in EndToEnd-ClientAndServer-Test.cfc and is called testEndToEndClientnewValidations. It looks like it's failing because the form is submitting, rather than displaying the JS failure message. This suggests that something is wrong with the JS on the form that is causing the validations to not fire. I ran the test off the develop branch and it passes, so it seems to be something from your code.

I'm going to push my current version to issue50 in the main repo. Can you please investigate?

bobsilverberg commented 13 years ago

Looks great John and all tests pass. Do you feel you've done everything you want to do regarding issue #50 and Dan's suggestions for performance improvements? If so I'll merge issue50 back into develop.