search

teamcfadvance / ValidateThis

An object oriented validation framework for ColdFusion objects
http://www.validatethis.org
44 stars 32 forks source link

Updated the ServerRuleValidator_Collection size #67

Closed gregmoser closed 12 years ago

gregmoser commented 12 years ago

I also added some new test case methods (although the test cases should be reviewed because I am new to MXUint).

In addition a new RB Key needed to be added

bobsilverberg commented 12 years ago

I pulled these changes but am getting test failures (4 of them) on the ServerRuleValidator_CollectionSizeTest.cfc tests. I am sending you back a pull request to grab what's in the branch here are run the tests yourself. If you get failures too please fix and send another pull request.

gregmoser commented 12 years ago

I pulled over all of the test updates that sent over. However, I have some questions about Unit tests in general and how to write them properly / understand what is already in place. I'm wondering if you might have a minute or two to get on a phone call or IM. I'm on skype all the time if that works (gregmoser1). If you don't have time to explain it to me, I totally understand I'm still going to try and figure it out on my own.

bobsilverberg commented 12 years ago

I would love to help you with this, but I am leaving for a week's vacation on Friday afternoon, so I'm not sure whether I'll be able to find time between now and then. If I do I'll look you up, if not I'll check in with you on my return.

gregmoser commented 12 years ago

Sounds good, no rush... have a great vacation.