teamcfadvance / ValidateThis

An object oriented validation framework for ColdFusion objects
http://www.validatethis.org
44 stars 32 forks source link

Failing Tests Out of the Box on Lucee #95

Open jamiejackson opened 8 years ago

jamiejackson commented 8 years ago

I'm writing some new features and I'd like to have code coverage for the new bits, as well as prevent regressions in the old bits, but there are a handful of failures right out of the box.

I took a look at a couple of them, but they weren't the sorts of things where it was clear what the intent was, so it wasn't easy to see if the problems were with the tests or with the code under test.

(Note, I'm running with https://github.com/teamcfadvance/ValidateThis/pull/94; otherwise, I wouldn't be able to run the tests at all.)

Functional Tests

http://127.0.0.1:40878/ValidateThis/functionalTests/run.cfm screenshot-127 0 0 1 40878 2016-05-31 16-41-53

Unit Tests

http://127.0.0.1:40878/ValidateThis/unitTests/run.cfm screenshot-127 0 0 1 40878 2016-05-31 16-40-05

I realize this isn't the most active project in the world, but if anyone can help me at least start with a firm test foundation, I'd be grateful.

jamiejackson commented 8 years ago

I just realized that the tests all pass in ACF9, but not in Lucee 4. That gives me something to work with.

cameroncf commented 8 years ago

Jamie-

I have yet to actually setup the tests since I started working on this project - I just sort of setup the project and started working on documentation but didn't get to even trying the automated tests. So you are already ahead of me on trying out the tests.

Looks like you are making some progress though!

-Cameron

jamiejackson commented 8 years ago

In https://github.com/teamcfadvance/ValidateThis/pull/94, I've now got all the functional tests working in Lucee 4, and four out of eight previously failing unit tests are now passing. (Four unit tests left.)

By the way, assuming I'm doing it right, testing is easy, if you've got the right stuff:

* I have a pull request (https://github.com/teamcfadvance/CFSelenium/pull/25) in for CFSelenium, too, which gets things working there.

Once the chips settle, I'll write this up in the readme, or something.