teamclouday / AndroidMic

Use your Android phone as a mic to Windows PC
MIT License
113 stars 9 forks source link

Android app UI update #11

Closed wiiznokes closed 1 year ago

wiiznokes commented 1 year ago

There is a lot of change, sorry :) -Ui made all with compose. -Marterial3 components. -UI revisited with a setting drawer with a choice for mode and IP/PORT. -Add Mode choice, in order to make connection faster and implementation of future mode easier (USB is not yet implemented but I will give it a try in the future (I'm not talking about USB tethering here)). -Set Ip and Port is now not handle by the service, the verification of a correct IP is made by the ViewModel. -Upgrade permission handle ( handle in compose function ). -Change the name of the application to AndroidMic (sorry about that it's just that is difficult to make a difference between a real mic recorder App and this App I think but I can change it if you want). -ForegroundService re-factorisation code.

I think this all major change I made. I started to implement SavedStateHandle in order to keep the UI states after a recomposition (rotation change) but that don't work for now (like the previous version). Maybe there is some bug with the lifecycle of Activity and AndroidViewModel (it's my first App using that and it's not well tested).

I hope you will enjoy this update and give me your thought! :)

teamclouday commented 1 year ago

Wow, thanks! I'll take a look.

The reason I call it Mic before is because having Android in the name of an app (which is already installed on Android system) is a bit strange. But yeah I agree this helps differentiate with the real mic app, so the new name AndroidMic sounds good.๐Ÿ™‚

Just curious, how would you approach the USB connection? Would there be a need to write a custom USB driver on Windows side?

teamclouday commented 1 year ago

Though I was not able to fully test the app, because of the liboboe.so issue, I tried the new UI!

Just a few suggestions:

Home screen

Image

Setting menu

Image Image

Let me know how you think! And thanks for your effort!

wiiznokes commented 1 year ago

Yes, I agree with everything you said. I will fix that. I was planning to change the small mistake after your opinion ahah. For the colors, I was on A12 so I did not pay attention of this color but I agree with you! Let me know if you could fully test the app.

teamclouday commented 1 year ago

Hey, just an update. I was able to downgrade Gradle and fully test the app! Everything works as expected ๐Ÿ‘\ You could continue to work with the current version, and I'll apply the version change once this pull request is merged.

wiiznokes commented 1 year ago

Hey, I'm happy you could fully tested the app, I made all the change to UI and I think it's look very great now! Let me now what your think.

teamclouday commented 1 year ago

Hey I've tried your latest update on the UI and it looks amazing! Great work๐Ÿ‘!

Just one small issue. The Record Audio text overlaps a little with the switch, on my phone:\

image

Perhaps this is not the same on your phone. I guess it is caused by different resolution and somewhere in code the UI uses fixed pixel sizes. Do you know if this can be fixed? (Maybe change the text to Record only in landscape mode, to match the width of button above)

Other than that, this looks great and I'm planning to merge it anytime. Let me know if you'll need to modify some more before the merge!

wiiznokes commented 1 year ago

It's good, you can merge it anytime๐Ÿ‘

teamclouday commented 1 year ago

Sounds good. Merged