search

teamclouday / AndroidMic

Use your Android phone as a mic to Windows PC
MIT License
113 stars 9 forks source link

Duplicate mutex in Android #30

Open graycatdeveloper opened 10 months ago

graycatdeveloper commented 10 months ago

Why do you need a copy of mutex in AudioBuffer on Android, if it is native? The call will be blocked anyway. And it's easier to make static mutex for thread safety.

teamclouday commented 10 months ago

Yea I see your point. It's more like a personal preference. Is there any performance related issues if I'm not making it static? I assume oboe will prevent recording start twice so there'll be only one mutex each time.