Open teamclouday opened 8 months ago
I'd suggest we use mono, 16000, i16 for the app and do not offer options to change them.
See #25 ahah.
I agree with you that these recording options (channels, sample rate) should be available in the app. I'm not actively working on this project, but will definitely try to implement these when I have time.
More seriously, I like having a lot of options, and the idea of having the best audio quality possible, but I understand that so many options can be confusing for an average user. That remains basic audio option tho.
And on rust server we can always resample up to 48000 stereo.
I'm not sure how you will do that, i means, if you don't recreate data like DLSS or smthg, what is the benefit?
Btw this pull request is just a fix for my device. I'm using 48000, mono, i16 on the app, and 48000, stereo, i16 for the rust server, and my audio device is 48000, stereo, f32.
If i remember correctly, you can use mono on the rust side. This is logic since you're recording in mono on the phone. It will automatically fall back to mono cloned strategy if your PC audio device doesn't support mono (like mine).
I've played with the rust server and modified a few things. My opinion is that there are too many choices:
I'd suggest we use
mono, 16000, i16
for the app and do not offer options to change them. And on rust server we can always resample up to 48000 stereo.Btw this pull request is just a fix for my device. I'm using 48000, mono, i16 on the app, and 48000, stereo, i16 for the rust server, and my audio device is 48000, stereo, f32.
Didn't see any issue with data order or formats. And yes UDP is super fast.
@wiiznokes