search

teamdigitale / dati-semantic-backend

Backend for the NDC semantic repository
GNU Affero General Public License v3.0
4 stars 5 forks source link

61 - exposing APIs for controlled vocabularies #12

Closed ginettev closed 2 years ago

ginettev commented 2 years ago

Co-authored-by: Keerthana keerthana.r@thoughtworks.com

ioggstream commented 2 years ago

@ash1425 WRT API parameter names there are some hints in the guidelines, eg. see https://docs.italia.it/italia/piano-triennale-ict/lg-modellointeroperabilita-docs/it/bozza/doc/04_Raccomandazioni%20di%20implementazione/05_raccomandazioni-tecniche-per-rest/02_progettazione-e-naming.html?highlight=offset

In this case, having the opportunity to review values using a yaml spec would be great :)

I was guessing whether in this use case it could be useful to implement cursor pagination...

ginettev commented 2 years ago

@ioggstream We have changed the code to use snake case for the request params now.

We have added page based pagination instead of cursor based pagination as it is easily supported by Elasticsearch. Also, specifying the page number and size seemed easier for the developers using the APIs too. We can discuss on this further if needed.