teamdigitale / dati-semantic-backend

Backend for the NDC semantic repository
GNU Affero General Public License v3.0
4 stars 5 forks source link

[BE] Support `assets/` paths #37

Closed ioggstream closed 11 months ago

ioggstream commented 2 years ago

I expect

To harvest first following paths:

assets/{ontologies,vocabularies,schemas}

Instead

It only procesesses ontopia-like paths Ontologie,VocabolariControllati

Possibili soluzioni

Extend the static class to support both, considering that Ontopia-like paths are a legacy.

A configuration parameter has been considered and excluded.

Clou-dia commented 1 year ago

Hi, how can we test it? @gnespolino

gnespolino commented 1 year ago

Hi, how can we test it? @gnespolino

It's released on dev and test environments, so yes. We also added Inail to the repo lists

Clou-dia commented 1 year ago

from dev or test I cannot see inail assets, I can only see the changes in the PR. What do you mean by "We also added Inail to the repo lists"? You changed the possible folder organization and name

gnespolino commented 1 year ago

from dev or test I cannot see inail assets, I can only see the changes in the PR. What do you mean by "We also added Inail to the repo lists"? You changed the possible folder organization and name

we added support for asset/** folder, leaving the legacy folder name support. So yes, Inail repo should be harvested now, but you probably we need to wait the harvester to run.

gnespolino commented 1 year ago

from dev or test I cannot see inail assets, I can only see the changes in the PR. What do you mean by "We also added Inail to the repo lists"? You changed the possible folder organization and name

I just triggered an harvesting manually both on dev and test, result should be visible in a couple of minutes.

Clou-dia commented 1 year ago

can you confirm this are the url: https://ndc-test.apps.cloudpub.testedev.istat.it/ https://ndc-dev.apps.cloudpub.testedev.istat.it/

Still didn't see anything from inail, so far.

gnespolino commented 1 year ago

can you confirm this are the url: https://ndc-test.apps.cloudpub.testedev.istat.it/ https://ndc-dev.apps.cloudpub.testedev.istat.it/

Still didn't see anything from inail, so far.

Good morning @Clou-dia, let me finish some work on it (there was a naming error in the vocabularies folder). I'll ping you when it's ready.

Clou-dia commented 1 year ago

https://github.com/teamdigitale/dati-semantic-backend/pull/78

Clou-dia commented 11 months ago

@gnespolino è risolto?

gnespolino commented 11 months ago

@gnespolino è risolto?

yes, legacy paths are still supported as well. New supported paths are here

Clou-dia commented 11 months ago

Verified, thanks