search

teamducro / gloomhaven-storyline

The spoiler free storyline tracker for Gloomhaven.
https://gloomhaven-storyline.com
71 stars 56 forks source link

Feature/font selector #220

Closed 1seanr closed 1 year ago

1seanr commented 1 year ago

Added a font selector,

It has however made some of the numbers a little too big in scale for the circles on the storyline page due to the offset but I'm unsure on how you would like that to be handled. The bigger numbers make it more readable its just that they are aligned slightly downright which makes it look a little crammed.

This is my first time using Vue and work has been crazy hence why it took a few weeks so feel free to nitpick as I am sure there are improvements.

The only bit that I am unsure of is lines 17-19 in resources/sass/theme.scss if I kept the original line I couldn't find any way to override it and it would cause the menu text options to only display in Nyala and not change like everything else but I'm sure there is a nicer way around it.

dducro commented 1 year ago

Thanks, I'll take a look at it soon!

1seanr commented 1 year ago

I wasn't sure what branch you want the pr merging into either sorry

On Thu, Feb 16, 2023 at 10:34 PM Daniël Ducro @.***> wrote:

Thanks, I'll take a look at it soon!

— Reply to this email directly, view it on GitHub https://github.com/teamducro/gloomhaven-storyline/pull/220#issuecomment-1432787351, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGHWQDQOFBQ7IABYPGBLRP3WXXYBBANCNFSM6AAAAAAU53ECVY . You are receiving this because you authored the thread.Message ID: @.***>

-- Thanks, Sean

dducro commented 1 year ago

@1seanr I merged it into a feature branch so I could make some changes. Thanks for your work! It's a great addition!

Do you have any input? I'll release it this weekend.

1seanr commented 1 year ago

Oh sweet,

The header/body/storyline text idea is a really good idea I thought the same when I was driving to work last week but by the time I reached work and had a chance to make a note I had completely forgotten. And fair enough removing from the user I didn't realise it required some API rework cause I couldn't get that working locally so I wasn't sure what it affected in that regards.

And sweet ill keep a lookout for it.

On a side note that attack modifier deck summary modal you added is really good!!! way better than I was hoping.

On Fri, Feb 17, 2023 at 11:21 PM Daniël Ducro @.***> wrote:

@1seanr https://github.com/1seanr I merged it into a feature branch so I could make some changes. Thanks for your work! It's a great addition!

  • I removed saving it to the user, this would involved some changes to the api, and I figured this feature is fine if it's client side only.
  • Added some checkboxes to apply the fonts to headers or the storyline, this way the user may choose to only apply it for regular texts and keep the headers or storyline original.

Do you have any input? I'll release it this weekend.

— Reply to this email directly, view it on GitHub https://github.com/teamducro/gloomhaven-storyline/pull/220#issuecomment-1435388428, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGHWQDQRRPYES2G64G27NWLWYABWZANCNFSM6AAAAAAU53ECVY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks, Sean