teamhephy / builder

MIT License
3 stars 12 forks source link

Use a cheaper way to ping the Kubernetes API in the health check endpoint #35

Open Cryptophobia opened 6 years ago

Cryptophobia commented 6 years ago

From @arschles on February 12, 2016 18:3

After #149, the health check server (/healthz) will be listing all namespaces in the cluster as a way to ping the Kubernetes API to determine whether it's available. This method of checking availability is more heavyweight than it has to be, since the API server should also have a healthz endpoint. Some code similar to the following should be used to check that endpoint:

// kubeClient is a *(k8s.io/kubernetes/pkg/client/unversioned).Client
res := kubeClient.Get().AbsPath("/healthz").Do()
if res.Error() != nil{
  // not possible to reach the server
}

This idea was first proposed by @aledbf in https://github.com/deis/builder/pull/149/files#r52692363

Copied from original issue: deis/builder#180

Cryptophobia commented 6 years ago

From @aledbf on February 12, 2016 22:30

@arschles this is a working version of the check

apiUrl := kubeClient.Get().AbsPath("/healthz").URL()
err := checkApiServer(apiUrl.String(), time.Duration(1*time.Second))
if err != nil {
  // something
}
// checkApiServer checks if is possible to reach the api server or not
func checkApiServer(url string, timeout time.Duration) error {
    // we don't know if the 
    client := http.Client{
        Timeout: timeout,
        Transport: &http.Transport{
            TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
        },
    }

    res, err := client.Get(url)
    if err != nil {
        return err
    }
    res.Body.Close()
    return nil
}
Cryptophobia commented 6 years ago

From @arschles on February 12, 2016 22:31

thanks @aledbf