search

teamhephy / builder

MIT License
3 stars 12 forks source link

chore(glide): upgrade and pin glide and fix distribution package #64

Closed Cryptophobia closed 4 years ago

Cryptophobia commented 4 years ago

Signed-off-by: Cryptophobia aouzounov@gmail.com

hephy/builder:v2.13.4 is failing to connect to minio and aws-s3 and doesn't start up inside the cluster. It is likely that the vendor directory broke and we were able to build by some glide cache luckiness...

Here, I have fixed the https://github.com/teamhephy/distribution dependency which serves as the entry-point to create the objectstorage interface inside the builder. Then I upgraded the glide.yaml versions of repositories that we depend on. Some have moved to go modules and I have pinned those to tags before they transitioned to go modules. Ideally we should move this project to go modules as soon as possible. :)

felixbuenemann commented 4 years ago

Not for me, glide-old.lock is checked in.

Cryptophobia commented 4 years ago

@felixbuenemann , thanks for the speedy response. It is not building for you?

I have included glide-old.lock just in case we need to look at the versions that worked before.

felixbuenemann commented 4 years ago

@Cryptophobia That's what git history is for, no need to keep the old file around.

Cryptophobia commented 4 years ago

:). @felixbuenemann, glide-old.lock is removed.

Cryptophobia commented 4 years ago

Had to upgrade to the hephy/go-dev:v1.26.2 and make a new image release in the repo - https://github.com/teamhephy/docker-go-dev/releases with the latest golinter tools. Now everything is passing. The previous build failures were strictly failures from the Go linter.