(WIP) Temporary fix for autoscale on k8s-1.9+

teamhephy / controller

Hephy Workflow Controller (API)

https://teamhephy.com

MIT License

14 stars 26 forks source link

(WIP) Temporary fix for autoscale on k8s-1.9+ #104

Closed ess closed 5 years ago

ess commented 5 years ago

This PR acts as a stopgap between the fix attempted in #86 and the whole-hog API capabilities work being done in #95 .

Effectively, this brings the changes from #86 back in, sanitizing the upstream API version number before the problematic comparison is done.

Just for an added bit of fun, I've included two related unit tests for Deployment.api_version to ensure proper behavior for cases that are already known.

Cryptophobia commented 5 years ago

Closed by https://github.com/teamhephy/controller/pull/106

Cryptophobia commented 5 years ago

Thank you for working on this @ess . I have brought your same change to the scheduler init function and added some test to make sure it works for Version parsing. The final changes with your commits are in https://github.com/teamhephy/controller/pull/106 . When I merge https://github.com/teamhephy/controller/pull/106 I will close here.