teamhephy / controller

Hephy Workflow Controller (API)
https://teamhephy.com
MIT License
14 stars 26 forks source link

feat(HPAs): resolves #135 recreate HPAs from db on load #136

Closed Cryptophobia closed 3 years ago

Cryptophobia commented 3 years ago

Signed-off-by: Cryptophobia aouzounov@gmail.com

resolves #135

@dmcnaught @kingdonb

Local unit test and local minikube testing passes for me. Had to modify the function.

There are multiple appsettings per app. We only care about the latest one. We use app.structure for the proc_types only if appsettings.autoscale is set. If autoscale is unset on deis, then the hpa should not be created and should return an error.

This is the intended behaviour as we assume deis/hephy controller is master of its own namespaces (apps).

Cryptophobia commented 3 years ago

Local unit test and local minikube testing passes for me. Had to modify the function.

There are multiple appsettings per app. We only care about the latest one. We use app.structure for the proc_types only if appsettings.autoscale is set. If autoscale is unset on deis, then the hpa should not be created and should return an error.

This is the intended behaviour as we assume deis/hephy controller is master of its own namespaces (apps).