search

teamhephy / controller

Hephy Workflow Controller (API)
https://teamhephy.com
MIT License
14 stars 26 forks source link

WIP: Conn max age #139

Closed kingdonb closed 3 years ago

kingdonb commented 3 years ago

Replaces #75, now that #137 is merged this PR is just focused on Conn Max Age setting.

I'm still not understanding what failed or why there are two settings for CONN_MAX_AGE, but we can close #75 and continue the discussion here if needed. (Or go ahead and merge once tested 👍 )

I will squash out the WIP commits before merge

kingdonb commented 3 years ago

I looked at this again in some more detail, tried to understand how CONN_MAX_AGE is used, tried to understand how Django imports the production DATABASE settings, I am not really a Django person and this looks like magic I don't know or understand. I'm also not sure why we wanted to set CONN_MAX_AGE, I think this change belonged to someone else.

I'm going to close it, but feel free to reopen if there is any need to set CONN_MAX_AGE. I'm not prepared to shepherd this change into the next release myself, particularly not being aware of the 'Why' makes it difficult to do testing effectively.

kingdonb commented 3 years ago

I really don't know but saw this failed and wanted to try translating from string parameters into an int,

Maybe needs to be translated into a float https://github.com/teamhephy/controller/pull/75#issuecomment-731904057, but hopefully floats and ints can get along with the + operator... let's just see if this fixes the build, then we can close (until someone comes along with a reason for needing to set CONN_MAX_AGE)

kingdonb commented 3 years ago

So, that just failed in a different way. Closing until someone needs CONN_MAX_AGE, unless someone else know how to fix this easily.