teamhephy / controller

Hephy Workflow Controller (API)
https://teamhephy.com
MIT License
14 stars 26 forks source link

Can't remove user's permission from an app when username is an email address #162

Closed dvalfre closed 2 years ago

dvalfre commented 2 years ago

It seems like Controller is not keen on understanding usernames with email address format for certain operations.

Steps to reproduce:

Current Behaviour The command fails with '404'

Expected Behaviour Permissions to access that app are removed for the specified user.

eudalov commented 2 years ago

The fix for the issue suggested: https://github.com/teamhephy/controller/pull/164.

Cryptophobia commented 2 years ago

Thank you for contribution @eudalov ! Merged in https://github.com/teamhephy/controller/pull/164.

In the future, just a note, can you format the PR and commit message to follow this guideline: https://docs.teamhephy.com/contributing/submitting-a-pull-request/

eudalov commented 2 years ago

Welcome. Ok.