Ability to cancel a deploy

teamhephy / controller

Hephy Workflow Controller (API)

https://teamhephy.com

MIT License

14 stars 26 forks source link

Ability to cancel a deploy #55

Open Cryptophobia opened 6 years ago

Cryptophobia commented 6 years ago

From @helgi on September 15, 2016 21:19

Ability to cancel a deployment (deis deploy:cancel), but the question is will it create:

a new release in Deis (allows for doing a "log" but release is still kept around)
rollback in k8s (no log / audit trail)

This will require a CLI change as well

Copied from original issue: deis/controller#1071

Cryptophobia commented 6 years ago

From @bacongobbler on September 15, 2016 21:25

Like as in a git push or a deis pull? Would it be easier to handle an interrupted HTTP connection instead?

Cryptophobia commented 6 years ago

From @helgi on September 15, 2016 21:34

Either - It's to unclog things when Deployment is "in progress" but is not failing (no image pull problems, etc) and you realise you want to cancel it without having to potentially wait for the full timeout.

Handling an interrupted HTTP connection is a double edge sword since those can keep going just fine thanks to Deployment.