search

teamhephy / controller

Hephy Workflow Controller (API)
https://teamhephy.com
MIT License
14 stars 26 forks source link

(WIP) Added support for AWS ECR #96

Closed mrferos closed 5 years ago

mrferos commented 5 years ago

Hi, wanted to get feedback on a more elegant way of integrating ECR, if that is something that would interest the Hephy team.

So far as I'm aware the authorization token is not guaranteed to stay static so I decided to modify the controller to pull the auth details if the registry username is aws-ecr.

Unsure of how up to date the contributing documentation is so please let me know if I've missed something glaring.

TODO

Cryptophobia commented 5 years ago

Hi @mrferos , thank you for the PR!

Could you reformat the commit messages to form to our style? We use a tool that takes greps the commit messages and creates changelogs when creating releases and that's why this step is necessary.

https://docs.teamhephy.com/contributing/submitting-a-pull-request/#commit-style

mrferos commented 5 years ago

@Cryptophobia I totally missed that in the documentation, the pre-existing support for ECR. I can close this PR and just depend on the existing solution?

Cryptophobia commented 5 years ago

@Cryptophobia I totally missed that in the documentation, the pre-existing support for ECR. I can close this PR and just depend on the existing solution?

Yes, I hope the documentation helps. Let us know if you are having any issues and you can always reach us on slack with any questions https://slack.teamhephy.com . :+1: