search

teamhephy / logger

MIT License
0 stars 2 forks source link

Write unit tests for the code herein #7

Open Cryptophobia opened 6 years ago

Cryptophobia commented 6 years ago

From @arschles on April 13, 2016 16:33

Important sections of this codebase are protected by sync.Mutexes or sync.RWMutexes, so special attention should be paid to writing concurrent tests (so that we can run go test -race)

Copied from original issue: deis/logger#57

Cryptophobia commented 6 years ago

From @arschles on April 21, 2016 15:47

Punting to beta4

Cryptophobia commented 6 years ago

From @arschles on May 9, 2016 19:58

I'm moving this to RC1. Also note that I haven't looked at the state of the code or amount of coverage in unit tests yet. I just noticed that there are not many...

Cryptophobia commented 6 years ago

From @bacongobbler on May 19, 2016 18:44

reclassifying as tests rather than a bug

Cryptophobia commented 6 years ago

From @bacongobbler on May 19, 2016 18:45

@jchauncey would you be willing to take a crack at this or shall we punt to post-2.0?

Cryptophobia commented 6 years ago

From @jchauncey on May 19, 2016 19:25

i have tests in stdout-metrics that does a lot of what we want to test in logger i just need time to port them. but yeah we should just wait

Cryptophobia commented 6 years ago

From @Joshua-Anderson on September 9, 2016 20:27

@jchauncey Were said unit tests ever written? It looks like the logger had 70% coverage, though with recent refactors has fallen to 40%