teamhephy / minio

MIT License
0 stars 4 forks source link

More upgrades #6

Open kingdonb opened 5 years ago

kingdonb commented 5 years ago

Reading the logs of minio pod on a freshly deployed v2.20.0 (or v2.20.1-beta) hephy workflow with the default settings, indicates that more things have changed since #2

2019/02/11 02:26:00 starting Minio server
2019/02/11 02:26:00 starting health check server on 0.0.0.0:8082
minio server /home/minio/

 You are running an older version of Minio released 3 months ago
 Update: https://docs.minio.io/docs/deploy-minio-on-kubernetes

Configuration file /home/minio/.minio/config.json migrated from version '2' to '3' successfully.
Configuration file /home/minio/.minio/config.json migrated from version '3' to '4' successfully.
Configuration file /home/minio/.minio/config.json migrated from version '4' to '5' successfully.
Configuration file /home/minio/.minio/config.json migrated from version '5' to '6' successfully.
Configuration file /home/minio/.minio/config.json migrated from version '6' to '7' successfully.
...
Configuration file /home/minio/.minio/config.json migrated from version '27' to '28' successfully.
Configuration file config/config.json migrated from version '28' to '29' successfully.
Configuration file config/config.json migrated from version '29' to '30' successfully.
Configuration file config/config.json migrated from version '30' to '31' successfully.
Endpoint:  http://172.17.0.14:9000  http://127.0.0.1:9000

Browser Access:
   http://172.17.0.14:9000  http://127.0.0.1:9000

Object API (Amazon S3 compatible):
   Go:         https://docs.minio.io/docs/golang-client-quickstart-guide
   Java:       https://docs.minio.io/docs/java-client-quickstart-guide
   Python:     https://docs.minio.io/docs/python-client-quickstart-guide
   JavaScript: https://docs.minio.io/docs/javascript-client-quickstart-guide
   .NET:       https://docs.minio.io/docs/dotnet-client-quickstart-guide

This stuff all comes from boot.go, which places the initial key file that gets migrated and migrated, and migrated. It looks like $HOME/.minio is not the place where it should live anymore, either.

I'm opening a PR to upgrade again, and fix up some of this log spam.

kingdonb commented 5 years ago

The PR in #7 does half of what I just said. It is probably safe to merge before the next release. I haven't tested it, will test later today. (It should be safe to merge and release without the other half.)

Cryptophobia commented 5 years ago

Great! Thanks for noticing this during manual testing @kingdonb ! Let's try to get it fixed for Hephy Workflow v2.20.2 :smile_cat:

Cryptophobia commented 4 years ago

Can you take a look at this sometime soon @kingdonb ? It's not urgent but it would be nice to have less output when the image runs.

kingdonb commented 4 years ago

I still intend to take a look at this... http://kb.commits.to/address-builder-storage-issue-in-hephy-workflow-by-wednesday

Cryptophobia commented 4 years ago

@kingdonb , we should probably update the version again and move some files around to where the new version expects them to be? Sounds like that is all that is required here. Should be a non-breaking change.

Cryptophobia commented 4 years ago

@kingdonb , can you take some time to look at this minio upgrade and moving around of the file structure before 2.22.1 release?