teamhephy / router

MIT License
4 stars 10 forks source link

Config builder silently fails with missing annotations #8

Open Cryptophobia opened 6 years ago

Cryptophobia commented 6 years ago

From @madisonhope on July 28, 2017 2:8

Somehow during a cluster upgrade, any apps that had multiple domains lost some of their annotations. router.deis.io/ssl.enforce and router.deis.io/domains were both missing, making the apps non-routable, even if deis routing:disable and deis routing:enable are run. There doesn't appear to be a command to rebuild/validate/correct service annotations and this doesn't log any errors.

Copied from original issue: deis/router#352

Cryptophobia commented 6 years ago

From @krancour on July 28, 2017 19:14

This cannot possibly be a router bug. The router only reads k8s resources. It never modifies them in any way, so if an annotation has gone missing from a service, the router is the victim of that; not the culprit.

Somehow during a cluster upgrade...

Can you clarify what you mean by this? You were upgrading Workflow? Or you were upgrading Kubernetes?

My gut wonders if k8s underlying etcd cluster is healthy.