search

teamhephy / workflow-cli

MIT License
2 stars 13 forks source link

config:push with .env doesn't handle export or double quotes #13

Open Cryptophobia opened 6 years ago

Cryptophobia commented 6 years ago

From @deis-admin on January 19, 2017 21:8

From @glenwong on June 4, 2015 23:19

If you have environment variables in your .env file that are surrounded by double quotes or start with an export they aren't handled correctly when pushed to deis. For example:

export REDIS_URL="redis://localhost:6379"

ends up as

export REDIS_URL: "redis://localhost:6379"

Where "export REDIS_URL" is the key and the value is still surrounded by double quotes which can then cause things to fail when the config is referenced.

Copied from original issue: deis/deis#3796

Copied from original issue: deis/workflow-cli#289

Cryptophobia commented 6 years ago

From @deis-admin on January 19, 2017 21:8

From @mboersma on June 10, 2015 21:24

Are env vars containing spaces in their names legal on Heroku? If not, we should tighten the .env file validation rules; if so, we should probably document config:push and config:pull behavior more specifically around this case.

Cryptophobia commented 6 years ago

From @deis-admin on January 19, 2017 21:8

From @bacongobbler on June 18, 2016 7:14

same answer as I laid out in https://github.com/deis/deis/issues/4512; we should move to a shared library or follow the spec laid out in https://github.com/bkeepers/dotenv#usage.

Cryptophobia commented 6 years ago

From @jeroenvisser101 on January 26, 2017 13:38

We're had the same bug a few times. Locally they work fine using Foreman, but in prod they fail.